----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126079/#review88395 -----------------------------------------------------------
Looks good, a comment on why that line is there would be useful. - Martin Klapetek On Nov. 16, 2015, 12:48 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126079/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 12:48 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > If dragging halfway above the top entry we end up with targetRow == -1 > which then tried to access out of bounds and crashes. > > BUG: 355365 > > > Diffs > ----- > > applets/kickoff/package/contents/ui/FavoritesView.qml > 901b80a2343700ca4054bc46aee703f0cfd26372 > > Diff: https://git.reviewboard.kde.org/r/126079/diff/ > > > Testing > ------- > > Dragged in all places, seems to still work. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
