> On Nov. 11, 2015, 11:46 p.m., David Edmundson wrote: > > pretty sure this breaks slackware > > > > might have to make it an option > > Martin Gräßlin wrote: > yes it breaks slackware and probably also BSDs. So -2 on this approach.
Thanks for the comments - I see, it breaks in non-PAM setups (which we also want to support in Gentoo). I'll try to come up with something better - closing RR for now. - Elias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126037/#review88275 ----------------------------------------------------------- On Nov. 11, 2015, 11:37 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126037/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2015, 11:37 p.m.) > > > Review request for Plasma, Bhushan Shah and Martin Gräßlin. > > > Repository: kscreenlocker > > > Description > ------- > > Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}. > > kcheckpass works just fine without setuid nowadays and quite a few > distributions already dropped setuid of if since quite some time. > > Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants > for consistency. > > > Diffs > ----- > > config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca > greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d > kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 > > Diff: https://git.reviewboard.kde.org/r/126037/diff/ > > > Testing > ------- > > `kcheckpass` and `kscreenlocker_greet` end up in the expected target > directory (`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected. > I'm not sure yet about `kscreenlocker_greet` as I ended up with an > un-unlockable session but also saw this issue before. > > > Thanks, > > Elias Probst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
