----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126016/#review88236 -----------------------------------------------------------
personal comment from X world: this is horrible, horrible ;-) What we should try is to make the desktop file available to the window. With KF 5.16 we will have all that's needed available. Let's try to improve this in Plasma 5.5 and scratch the code completely. libtaskmanager/taskitem.cpp (line 627) <https://git.reviewboard.kde.org/r/126016/#comment60505> don't we have to change to kdeinit5 here? - Martin Gräßlin On Nov. 10, 2015, 7:54 p.m., Johan Ouwerkerk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126016/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 7:54 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Previously the taskmanager library contained a special case logic for windows > of KDE-4 KCM modules (only). > These modules were recognised by finding wmClass=Kcmshell4. > This logic is extended to cover kcmshell5 windows as well, meaning that KCMs > written for Plasma 5 are properly recognised now. > The net benefit is that these KCMs are displayed in the task manager with > their proper KCM program icons. > > This patch can be pulled from the kcmshell5-task-url-fixes branch at: > g...@github.com:cmacq2/plasma-workspace.git > > > Diffs > ----- > > libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e > > Diff: https://git.reviewboard.kde.org/r/126016/diff/ > > > Testing > ------- > > Built with kdesrc-build, and tested using: `plasmawindowed > org.kde.plasma.icontasks`. > I checked the change works as expected by running `which kcmshell5` style as > well as `kcmshell5 style`: the icon of the window matches that in system > settings (as expected). > > > Thanks, > > Johan Ouwerkerk > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
