----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126018/#review88227 -----------------------------------------------------------
Ship it! > should I change also X-KDE-System-Settings-Category=notification to > notifications I don't think so, it would require changing everywhere. Unless there is nothing actually using it, in which case, yes. - Martin Klapetek On Nov. 10, 2015, 10:12 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126018/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 10:12 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > ------- > > The word used to be plural (even if combined with other words) in the > previous major version of Plasma. > > Question: if accepted, should I change also > X-KDE-System-Settings-Category=notification to notifications, or would it be > not worth of? > > > Diffs > ----- > > categories/settings-personalization-notification.desktop 24fee0d > > Diff: https://git.reviewboard.kde.org/r/126018/diff/ > > > Testing > ------- > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
