----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/#review88206 -----------------------------------------------------------
src/declarativeimports/calendar/eventpluginsmanager.cpp (line 42) <https://git.reviewboard.kde.org/r/125951/#comment60491> please use QByteArrayLiteral("configUi") src/declarativeimports/calendar/eventpluginsmanager.cpp (line 68) <https://git.reviewboard.kde.org/r/125951/#comment60490> QStringLiteral("MetaData"). this is important because data() method is called a lot. src/declarativeimports/calendar/eventpluginsmanager.cpp (line 79) <https://git.reviewboard.kde.org/r/125951/#comment60489> in order to reduce malloc/free call count (and the data() method is called a lot) please use leftRef() instead of left() and % instead of + three lines below (or make sure + is the same as % by adding define -DQT_USE_QSTRINGBUILDER) - Nick Shaforostoff On Nov. 9, 2015, 7:56 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125951/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 7:56 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This is also made a QML singleton that will be used for the applet > config view where it will add the plugin configs once we add that > possibility. > > The same instance is then set to the DaysModel from QML. > > (this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship > it) > > > Diffs > ----- > > src/declarativeimports/calendar/CMakeLists.txt > 40ead911ad5208cae5dbe5333d227f9f8a0d9154 > src/declarativeimports/calendar/calendarplugin.cpp > bafe80cf7520a08312abfd1dbd6d4648a6710175 > src/declarativeimports/calendar/daysmodel.h > a5bdac98627f7efa76bd4afd239469b53e06690b > src/declarativeimports/calendar/daysmodel.cpp > 2d059a8e8636565adbe52811e602fff37a5eb157 > src/declarativeimports/calendar/eventpluginsmanager.h PRE-CREATION > src/declarativeimports/calendar/eventpluginsmanager.cpp PRE-CREATION > src/declarativeimports/calendar/qml/MonthView.qml > f698934f850ef3a917b9611c9f9a40c369b23f6c > > Diff: https://git.reviewboard.kde.org/r/125951/diff/ > > > Testing > ------- > > Calendar events are still correctly displayed > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
