----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125939/#review88073 -----------------------------------------------------------
Ship it! Been investigating. Changed my mind, ship it! Make sure to comment in the code though. - David Edmundson On Nov. 3, 2015, 9:10 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125939/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 9:10 p.m.) > > > Review request for Plasma. > > > Bugs: 353779 > http://bugs.kde.org/show_bug.cgi?id=353779 > > > Repository: plasma-framework > > > Description > ------- > > I have really no idea what's happening and this patch is plain wrong but I > cannot figure out why this happens. Basically, if I popup() the "determining > minetype" thing afterwards if the menu becomes empty for whatever reason > (clear(), remove the one and only action in it etc) it just self-destructs in > exec() and returns a null QAction. > Any idea what's going on there? > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f > > Diff: https://git.reviewboard.kde.org/r/125939/diff/ > > > Testing > ------- > > Now I can drop stuff that offers multiple actions (image for instance will > yield an icon and "use as wallpaper") and actually choose from them. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
