----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/#review87751 -----------------------------------------------------------
src/client/plasmawindowmanagement.h (line 243) <https://git.reviewboard.kde.org/r/125871/#comment60204> "setMinimizedGeometry[On]"? src/client/plasmawindowmanagement.h (line 248) <https://git.reviewboard.kde.org/r/125871/#comment60205> "unset/forget/releaseMinmizedGeometry[On]"? src/server/plasmawindowmanagement_interface.cpp (line 455) <https://git.reviewboard.kde.org/r/125871/#comment60201> if (panelSurface) ... src/server/plasmawindowmanagement_interface.cpp (line 459) <https://git.reviewboard.kde.org/r/125871/#comment60202> if (p->taskGeometries.remove(.)) ... src/server/plasmawindowmanagement_interface.cpp (line 467) <https://git.reviewboard.kde.org/r/125871/#comment60203> same checks here - Thomas Lübking On Okt. 30, 2015, 2:15 nachm., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125871/ > ----------------------------------------------------------- > > (Updated Okt. 30, 2015, 2:15 nachm.) > > > Review request for kwin and Plasma. > > > Repository: kwayland > > > Description > ------- > > this exposes the geometry of taskbar entries in plasma-windowmanagement, in > order to make the minimize effects possible. > unlike on X11, it takes relative positions and it has one geometry per panel, > making possible to have multiple taskbars working. > > however this is still not completely exposed, as internally kwin has still > only one geometry, it will need a change in kwin itself (suggestions welcome) > probably the rotocol will need also a minimizeTo function that takes the > panel as argument. > > another thing completely missing is tests: unfortunately the whole > plasma-windowmanagement doesn't have any autotest yet :/ > > > Diffs > ----- > > autotests/client/CMakeLists.txt 1556c47 > autotests/client/test_wayland_windowmanagement.cpp PRE-CREATION > src/client/plasmawindowmanagement.h abd8fa6 > src/client/plasmawindowmanagement.cpp 1f9674c > src/client/plasmawindowmodel.h 5a6aac4 > src/client/plasmawindowmodel.cpp 355ef53 > src/client/protocols/plasma-window-management.xml ca6a7cc > src/server/plasmashell_interface.h 9db3f52 > src/server/plasmashell_interface.cpp d29d7bc > src/server/plasmawindowmanagement_interface.h 6ccc22e > src/server/plasmawindowmanagement_interface.cpp ad714a5 > > Diff: https://git.reviewboard.kde.org/r/125871/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
