----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125864/#review87678 -----------------------------------------------------------
Ship it! Some minor things, otherwise, go for it. It looks nice. applets/digital-clock/package/contents/ui/CalendarView.qml (line 39) <https://git.reviewboard.kde.org/r/125864/#comment60160> Could you clean this out before committing as well? (I know, nothing to do with your patch, just noticed it.) applets/digital-clock/package/contents/ui/CalendarView.qml (line 81) <https://git.reviewboard.kde.org/r/125864/#comment60156> Resetting (typo) applets/digital-clock/package/contents/ui/CalendarView.qml (line 92) <https://git.reviewboard.kde.org/r/125864/#comment60158> if (updatedData === monthView.currentDate) ? I don't know if js date comparisons work that well, but seems simpler and clearer... applets/digital-clock/package/contents/ui/CalendarView.qml (line 106) <https://git.reviewboard.kde.org/r/125864/#comment60159> 0.6 opacity is more commonly used, I'd suggest using that here as well. - Sebastian Kügler On Oct. 29, 2015, 4:24 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125864/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 4:24 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Adds back the Agenda that was there pre-5.0 with some changes. > > It now shows an overview of the given day events/holidays. I'd > like to add a second view at some point that would show you the > selected day by hours but that is much more work and the freeze > is getting closer, so maybe that will have to wait till 5.6. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/CalendarView.qml b52eb10 > > Diff: https://git.reviewboard.kde.org/r/125864/diff/ > > > Testing > ------- > > Selecting a day correctly changes the date in the agenda and correctly > displays the events of the day. > > Event removal/modification also removes/modifies it from the agenda. > > > File Attachments > ---------------- > > Current look in Breeze > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/5485250c-8d20-409e-8a5b-0eda7a9d7b8d__snapshot29.png > Multiple same-day events > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d453a01e-f9cf-4da3-8f6a-fac5aa6aadf5__snapshot18.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
