> On Oct. 28, 2015, 6:18 p.m., Hrvoje Senjan wrote: > > ksmserver/screenlocker/CMakeLists.txt, line 41 > > <https://git.reviewboard.kde.org/r/125838/diff/2/?file=413118#file413118line41> > > > > if this will be shared lib, please extract private vs. public deps.
I am not sure how to extract private vs public deps.. but I think it is about what is used in public headers, right? - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87575 ----------------------------------------------------------- On Oct. 28, 2015, 4:37 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125838/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 4:37 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > To make screenlocker in wayland possible, kwin_wayland will need to link to > libksld. > > (if packagers can look at this patch it would be nice) > > > Diffs > ----- > > ksmserver/CMakeLists.txt a0c8852 > ksmserver/screenlocker/CMakeLists.txt 5ded06e > ksmserver/screenlocker/autotests/CMakeLists.txt 7e7acdc > ksmserver/screenlocker/ksldapp.h 9058824 > ksmserver/screenlocker/tests/CMakeLists.txt 7f0db74 > > Diff: https://git.reviewboard.kde.org/r/125838/diff/ > > > Testing > ------- > > builds/installs and tests pass > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
