----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125827/#review87502 -----------------------------------------------------------
ksmserver/screenlocker/ksldapp.cpp (lines 145 - 154) <https://git.reviewboard.kde.org/r/125827/#comment60080> Not being on wayland doesn't imply X11. Do test for X11 please: if (QX11Info::isPlatformX11()) suggestion: add a new private method called initializeX11() ksmserver/screenlocker/ksldapp.cpp (lines 404 - 406) <https://git.reviewboard.kde.org/r/125827/#comment60082> same here: check for X11, not for Wayland - Martin Gräßlin On Oct. 27, 2015, 11:51 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125827/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 11:51 a.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > At this moment WaylandLocker is just no-op, but X11Locker being highly X > dependant this provides default implementation for lockwindow. > > > Diffs > ----- > > ksmserver/screenlocker/CMakeLists.txt 367e81e > ksmserver/screenlocker/ksldapp.cpp f5dd998 > ksmserver/screenlocker/waylandlocker.h PRE-CREATION > ksmserver/screenlocker/waylandlocker.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125827/diff/ > > > Testing > ------- > > works : http://i.imgur.com/d0ZCuO7.png > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
