> On Oct. 24, 2015, 12:44 p.m., Kai Uwe Broulik wrote: > > dataengines/notifications/notificationsengine.cpp, lines 375-376 > > <https://git.reviewboard.kde.org/r/125770/diff/1/?file=412438#file412438line375> > > > > I would turn the comment around "Only if we have that notification ..."
That gets more confusing. I want to emphasise the "we don't emit twice" rather than "we emit the first time" Hopefully tidied up - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125770/#review87336 ----------------------------------------------------------- On Oct. 24, 2015, 12:40 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125770/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 12:40 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Expired notifications should emit a different reason in > NotificationClosed than manually closed notifications > > See > https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-1.1.html#signal-notification-closed > > BUG: 354293 > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationPopup.qml > 5fd06bb4ee437e673ef9cc09907764b40cfa5a74 > applets/notifications/package/contents/ui/Notifications.qml > 13be7d49a14ebbe5399a7f0bf333862f545671a2 > dataengines/notifications/notificationaction.cpp > 5302f7808fd43c924a3f7b1fd7cfc0acba45c500 > dataengines/notifications/notifications.operations > 046776ec1af981d7fb23db9ddb9bd9d34ec55300 > dataengines/notifications/notificationsengine.h > 52590950ad1c85f427502b598e0b21d8a65e587e > dataengines/notifications/notificationsengine.cpp > 42e56d8ab27b3a012381cbd0ce39c6322d09e152 > > Diff: https://git.reviewboard.kde.org/r/125770/diff/ > > > Testing > ------- > > Ran dbus-monitor & notify-send > > let one notification expire > clicked close on another > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
