> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/sniproxy.cpp, lines 180-183 > > <https://git.reviewboard.kde.org/r/125655/diff/1/?file=411304#file411304line180> > > > > maybe you could use the sync protocol?
xsync would make sense, except there doesn't seem to be one in XCB. as for the sync protocol, http://www.x.org/releases/X11R7.7/doc/xextproto/sync.html#Types I don't see how I would use that here? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review86912 ----------------------------------------------------------- On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125655/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 11:22 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > The goal of this project is to make xembed system trays available in Plasma. > > This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] > available in Plasma which only supports StatusNotifierItem [2]. > > Ideally we also want this to work in an xwayland session, making X system > tray icons available even when plasmashell only has a wayland connection. > > How it works (in theory) > > * We register a window as a system tray container > * We render embeded windows composited offscreen > * We render contents into an image and send this over DBus via the SNI > protocol > * XDamage events trigger a repaint > * Activate and context menu events are replyed via X send event into the > embedded container as left and right clicks > > > Code is a mix of hacks and bodges bashing client apps into place, and I > happily acknowledge it looks pretty bad. Unfotunately most of it seems to be > needed, but I'd love to be proved wrong on most of it. > > --- > > CMakeLists changes are obviously currently wrong, I can strip half of > find_packages and I need an add_subdirectory in the root file, but it's > easier for me to sync with the separate repo mirror this way till we're close > to merging. I expect this to take quite some revisions. > > > Diffs > ----- > > xembedsniproxy/CMakeLists.txt PRE-CREATION > xembedsniproxy/Readme.md PRE-CREATION > xembedsniproxy/fdoselectionmanager.h PRE-CREATION > xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION > xembedsniproxy/main.cpp PRE-CREATION > xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION > xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION > xembedsniproxy/snidbus.h PRE-CREATION > xembedsniproxy/snidbus.cpp PRE-CREATION > xembedsniproxy/sniproxy.h PRE-CREATION > xembedsniproxy/sniproxy.cpp PRE-CREATION > xembedsniproxy/xcbutils.h PRE-CREATION > xembedsniproxy/xembedsniproxy.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125655/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
