----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125694/#review87039 -----------------------------------------------------------
Ship it! Good job, thanks! :) - Aleix Pol Gonzalez On Oct. 19, 2015, 12:44 a.m., David Kahles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125694/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 12:44 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > To move the panels of screen [i] to the next screen, we should query for > the panels of DesktopView [i], not of DesktopView [i + 1]. Otherwise the > panels aren't shifted to the new screen. Thus QT shifted the > panels itself, but hid them afterwards. Besides the panels were not > visible, it raised an assert in screenInvariants(). > > > Diffs > ----- > > shell/shellcorona.cpp 9185fb58a5e7ca09f916bbc5a231e7220a562c85 > > Diff: https://git.reviewboard.kde.org/r/125694/diff/ > > > Testing > ------- > > The panel now gets shifted correctly when unplugging a screen. I tested it > only with 2 screens, i'm not sure whether this loop works with more than 2 > screens, this needs more investigation.. > > > Thanks, > > David Kahles > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
