----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125686/#review87010 -----------------------------------------------------------
+1 - Kai Uwe Broulik On Okt. 18, 2015, 11:23 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125686/ > ----------------------------------------------------------- > > (Updated Okt. 18, 2015, 11:23 vorm.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > Basically dead code given that Plasma doesn't have a dedicated dashboard > mode anymore and also doesn't set the required window role for it to > work. > > By deleting we save one string comparison for each newly opened window. > > > Diffs > ----- > > effects/CMakeLists.txt 3e88bfa754bf1581d5e951b602838746a3826acd > effects/dashboard/CMakeLists.txt 81c5ee1ff878904ab06153e2e316775218d799ae > effects/dashboard/dashboard.h 9c46f12ebf5c222ba91a9f153b1f84671c25de82 > effects/dashboard/dashboard.cpp 42651ecce1b8a3189e5b47382b4915b76adb1aec > effects/dashboard/dashboard.kcfg 9fbdf09c5a45181f3099ef1e7a8777416f14d6b9 > effects/dashboard/dashboard_config.h > aaa09d6fb9f3b82faa7a073826ca725e0739886e > effects/dashboard/dashboard_config.cpp > 75696bd07b45ff0247fc39a8ca058bd392f2e681 > effects/dashboard/dashboard_config.desktop > de25b623bcb79012f9bbb3222c1ac1916dbfdcea > effects/dashboard/dashboard_config.ui > fd9a19e0c5b979049fe7e3443974eef3286fb2f2 > effects/dashboard/dashboardconfig.kcfgc > 772ad03cbe6f5f213759d394a54eeede08411bf0 > effects/effect_builtins.h b471cf077a2bb284ac448229c9967b00023d8842 > effects/effect_builtins.cpp be508e6fea57be49a1bd320194f18aaeb1465f42 > > Diff: https://git.reviewboard.kde.org/r/125686/diff/ > > > Testing > ------- > > Compiles without the effect. Verified that "plasma-dashboard" is nowhere set > in plasma-framework, plasma-workspace and plasma-desktop. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
