> On Oct. 17, 2015, 9:58 a.m., Kai Uwe Broulik wrote: > > Btw what should be do with the "Show Dashboard" entry in the desktop > > toolbox? I mean, if you can actually use the toolbox you can probably see > > your desktop anyway, so we could remove it altogether?
I don't think that's completely true, I have 6 windows open and I can see both desktop toolboxes. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125669/#review86945 ----------------------------------------------------------- On Oct. 17, 2015, 9:51 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125669/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2015, 9:51 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > We have a > > connect(KWindowSystem::self(), &KWindowSystem::showingDesktopChanged, > [dashboardAction](bool showing) { > dashboardAction->setText(showing ? i18n("Hide Dashboard") : > i18n("Show Dashboard")); > > in the class constructor. Changing when we're invoked manually is pointless. > > > Diffs > ----- > > shell/shellcorona.cpp b52a7a13b49be184915b1cb350d2e81fe4dffeac > > Diff: https://git.reviewboard.kde.org/r/125669/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
