> On Okt. 10, 2015, 5:56 nachm., Eike Hein wrote: > > Did you test to make sure it doesn't crash if a delegate is destroyed while > > the menu is open?
kdialog --sorry "foo" sleep 5; killall kdialog Right clicked its task manager entry Entry disappeared, menu closed, no crash - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125589/#review86650 ----------------------------------------------------------- On Okt. 10, 2015, 5:17 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125589/ > ----------------------------------------------------------- > > (Updated Okt. 10, 2015, 5:17 nachm.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Repository: plasma-desktop > > > Description > ------- > > One thing that always bugged me with the Plasma 5 Task Manager was the > context menu covering the task item (I have a top panel) when I, conforming > to Fitt's Law, threw my mouse at the edge and right clicked. > > This also restores Plasma 4 behavior where the context menus din't overlap > the panels. I chose to align the context menu with the item itself rather > than just the panel, which is what Plasma 4 did, to communicate some affinity > to the task item, especially in multi-row task managers. > > I changed the QMetaObject::invokeMethod to a QTimer::singleShot with lambda, > don't know if that's the right approach. Also it's perhaps not optimal for me > to copy the QPoint into the lambda. > > > Diffs > ----- > > applets/taskmanager/plugin/backend.h 2b9d9e9 > applets/taskmanager/plugin/backend.cpp 97ed755 > > Diff: https://git.reviewboard.kde.org/r/125589/diff/ > > > Testing > ------- > > Tested with single and multi row task manager in top/bottom/left/right > panels. Works. Did not test with multiple monitors. > > Perhaps some margins need to be taken into account additionally, note the > small gap between the indicator line and the menu border > > > File Attachments > ---------------- > > Outer left two columns > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/10/f62b81df-4b0b-4b11-8c66-aa96dc56850a__taskmanageroverlap1.png > Inner left two columns > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/10/7b128305-04e8-4734-82d0-b1853bbc8471__taskmanageroverlap2.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
