-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125089/#review86637
-----------------------------------------------------------

Ship it!


Ship It!

- David Kahles


On Sept. 7, 2015, 1:41 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125089/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 1:41 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Fix changing volume with horizontal scroll in applet compact representation.
> 
> Horizontal scroll was only lowering the volume when scrolling to both 
> directions.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/main.qml e86ddae 
> 
> Diff: https://git.reviewboard.kde.org/r/125089/diff/
> 
> 
> Testing
> -------
> 
> left/right scroll now lowers/raises volume.
> 
> Actually, left scroll raises the volume and right scroll lowers it. But I get 
> the same behavior as on Quick Controls Slider, so probably just bug with my 
> mouse (or it's reversed in Qt).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to