> On Oct. 9, 2015, 10:24 a.m., David Edmundson wrote:
> > >Still missing, something similar will have to be executed when a new
> > >containment is added as well.
> >
> > How would that differ from current LayoutTemplates?
>
> Marco Martin wrote:
> there is indeed a partial overlap that doesn't make me too happy :/
>
> the difference is that this script gets executed when a particular
> applet/containment gets added, so gets always the same configuration no
> matter what for that applet (with that for instance would be possible a
> feature request we once had of having a folderview dith ~/desktop1 on the
> first screen ~/desktop2 on the second and so on).
> A layout template is like "create a new default panel" but I can see how
> one could abuse this in order to make layout templates...
>
> Perhaps we could do that those are executed only in case of normal
> applets, and have the possibility to define in the l&f package to execute a
> particular layout template when a desktop for a view is created?
Yeah, there's also a partial overlap with loadDefaults.
Again, it's a /tiiiiny/ bit different in that it's only run once, but it's
basically the same as
if (applet==containment && containment.type == "desktop" && containment.screen
== 0) {
//existing code to add a panel or whatever
}
and using this mechanism here.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125562/#review86530
-----------------------------------------------------------
On Oct. 9, 2015, 11:08 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125562/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 11:08 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> (draft) mutually exclusive with https://git.reviewboard.kde.org/r/125558/
> a bit more flexible
> different approach: execute a script from the look and feel package when an
> applet is added, adding to the script environment "applet" that wraps the
> currently added applet and "containment" that wraps its containment.
> from there the javascript part can do anything it can do in the startup
> script as well.
> Still missing, something similar will have to be executed when a new
> containment is added as well.
>
>
> Diffs
> -----
>
> shell/packageplugins/lookandfeel/lookandfeel.cpp a6cef04
> shell/shellcorona.cpp 37d0534
>
> Diff: https://git.reviewboard.kde.org/r/125562/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
