> On Oct. 8, 2015, 9:48 a.m., Kai Uwe Broulik wrote: > > +1 from me > > > > I think the user of the effect wants the screen to darken and with that we > > should also prevent accidental mouse clicks. > > Martin Gräßlin wrote: > what about keyboard? > > Kai Uwe Broulik wrote: > Wait a Minute. Would intercepting the mouse also block KIdleTime? That's > bad then because PowerDevil uses the KScreen effect to alert the user the > system's going to suspend/turn off screen shortly. Wiggling the mouse should > cancel that. > > Martin Gräßlin wrote: > > Wait a Minute. Would intercepting the mouse also block KIdleTime? > > That depends a lot on how we implement it. If it grabs the mouse > KIdleTime would break. The change here uses the mouse interception in KWin > which does not grab the mouse - but that's kind of an implementation detail. > And I consider it wrong to use the mouse interception here as I think > grabmouse is wanted. > > The question means to me that implementing this in KWin is the wrong > place. If we want to have full control over it, it needs to go to the user of > the KScreen effect. That one can grab mouse/keyboard (though dangerous as > that breaks screen locking!) and then also knows whether the user wiggled the > input. > > Kai Uwe Broulik wrote: > Ok, I see, -1 then :) > > David Rosca wrote: > Actually, I just wanted to hide the cursor and the mouse interception > only came as a bonus when finding how to change cursor. > When suspending, this effect is used and there is a cursor even though > user has no way to cancel it (unlike before turning off screen). So indeed, > it would be better to change it in powerdevil.
For hiding the cursor there is dedicated API in XFixes - so also from powerdevil it shouldn't be too difficult to achieve it. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125547/#review86474 ----------------------------------------------------------- On Oct. 8, 2015, 11:32 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125547/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 11:32 a.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: kwin > > > Description > ------- > > The whole screen is turned black with kscreen effect, so we should intercept > mouse to prevent accidental clicks. > Also, it looks better with no visible cursor. > > > Diffs > ----- > > effects/kscreen/kscreen.cpp 67f4551 > > Diff: https://git.reviewboard.kde.org/r/125547/diff/ > > > Testing > ------- > > Cursor is hidden when effect is active. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
