On Tue, 29 Sep 2015 15:26:04 +0200 "kainz.a" <kain...@gmail.com> wrote:
> 2015-09-28 23:24 GMT+02:00 Sebastian Kügler <se...@kde.org>: > > > On Monday, September 28, 2015 20:33:33 Marco Martin wrote: > > > On Monday 28 September 2015, andreas kainz wrote: > > > > > On Sept. 28, 2015, 2:29 p.m., Eike Hein wrote: > > > > > > applets/showActivityManager/package/metadata.desktop, line > > > > > > 114 < > > https://git.reviewboard.kde.org/r/125437/diff/1/?file=408607#file4086 > > > > > > 0 > > > > > > 7line114> > > > > > > > > > > > > The applet icons aren't really part of the icon theme, > > > > > > but the icon > > > > > > spec does say "As a further restriction, all icon names > > > > > > may > > only > > > > > > contain lowercase letters, numbers, underscore, dash, > > > > > > or period characters." - maybe we should keep the lowercase > > > > > > restriction > > for > > > > > > our icon assets? It's not a big deal though. > > > > > > > > should I remove the org.kde.? I would prefere icon names like > > > > > > > > plasma-showactivitymanager > > > > > > > > according to our wiki > > > > > > https://github.com/NitruxSA/breeze-icon-theme/wiki/Icon-naming-and-categor > > > > ization-guidelines-in-Breeze > > > > > > fine with me, in that case is perhaps better to have > > > plasma-applet-showactivitymanager > > > to be really sure all names won't clash with something else some > > > day > > > > I'd prefer having the plugin name (so keeping the org.kde prefix) > > also used in > > the icon name, it's way easier to find the icon programmatically > > this way (even if we define it in the .desktop file). > > > > > I'd prefere the naming of app specific icons according to our > guidelines. hope it would work for you too Sebastian. I understand > that it is difficult to find the right widget name in the plasma > source code, cause the names are quite different, but this is no icon > name problem and of course widgets should have the same icon type > than all other apps. > > plasma-applet-showactivitymanager Which guidelines? The one hard guideline we have is plugin names. Dots are OK in icon names according to Eike, so why would we invent yet another name? -- sebas Sebastian Kügler | http://vizZzion.org | http://kde.org _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
