----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125433/#review86025 -----------------------------------------------------------
according to git blame I added this to help autoload the camera list ... although I have not much recall of this :/ - Marcus Meissner On Sept. 28, 2015, 5:09 a.m., Christian Butcher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125433/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 5:09 a.m.) > > > Review request for KDE Graphics and Plasma. > > > Repository: kamera > > > Description > ------- > > The displayGPSuccessDialogue(void) function calls load() as its last > statement currently. > > Documentation for the KCModule api (both > [kde4](http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKCModule.html) > and > [frameworks](http://api.kde.org/frameworks-api/frameworks5-apidocs/kconfigwidgets/html/classKCModule.html)) > informs the reader that load() is called at the end of construction - > consequently it seems that the additional load() call leads to the function > (which is implemented as KKameraConfig::load() ) being called twice. > > [Bug 236844](https://bugs.kde.org/show_bug.cgi?id=236844) may be related but > at least on my KF5 based system, this does not cause or prevent a crash, > which is referenced in the bug. > > Separately, COPYING-CMAKE-SCRIPTS is referenced by the FindGphoto2.cmake > file, and seems to have missed the commit in > [RR-125230](https://git.reviewboard.kde.org/r/125230/). If this was > intentional, then my apologies for readding here, but if so, the > FindGphoto2.cmake file will need changing in some way. > > > Diffs > ----- > > COPYING-CMAKE-SCRIPTS PRE-CREATION > kcontrol/kamera.cpp 2d8f61449a5a6f2650d864c864652ebea780a422 > kcontrol/kameradevice.h b0ecb974f8fcb765228afe1965aeebab8e7656ed > > Diff: https://git.reviewboard.kde.org/r/125433/diff/ > > > Testing > ------- > > When the call is present, opening the Kamera KCM within systemsettings after > saving changes and going back to the main systemsettings view leads to a > strange set of scrollbars. > > With the additional call removed, the KCM-Kamera opens properly on the second > attempt, after saving changes. > > As a camera to test, the first (in the scroll list) serial port camera is > 'Achiever Digital Adc65'. 'Barbie' may be easier to find as the first entry > for 'B', and is also more memorable... I used a serial camera, since then the > kcm will load images even without a camera connected > > > File Attachments > ---------------- > > scrollbars > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/28/74e8bd93-4c4a-4103-9fb1-7bd106258058__kcm1.png > > > Thanks, > > Christian Butcher > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
