----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125395/#review85928 -----------------------------------------------------------
+1, looks good! - Martin Klapetek On Sept. 25, 2015, 5:10 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125395/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 5:10 p.m.) > > > Review request for Plasma, Daniel Nicoletti and Harald Sitter. > > > Repository: print-manager > > > Description > ------- > > m_connectedEvents is modified in connectNotify which according to the > docs will be called from the thread of the caller, not this. > > A mutex around all places that use/modify it should prevent print manager > from making plasmashell crash. > > BUG: 345862 > > > Diffs > ----- > > libkcups/KCupsConnection.h f61ccb53078766e7f5e96dedec879b52b9083b66 > libkcups/KCupsConnection.cpp 482a0bcc9afdee9e0fa131da158988d349dd0da6 > > Diff: https://git.reviewboard.kde.org/r/125395/diff/ > > > Testing > ------- > > Applet still loads..though I don't have any printers, so can't test too much. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
