> On Sept. 23, 2015, 4:46 p.m., David Edmundson wrote:
> > src/plasma/private/applet_p.cpp, line 171
> > <https://git.reviewboard.kde.org/r/125336/diff/1/?file=404932#file404932line171>
> >
> > +1 to the idea,
> >
> > I'm not sure this is the right place though.
> > We have an applet::setIcon that can be called at runtime from any of
> > the applets.
> >
> > Arguably that should be allowed to use the "/foo" format too
>
> Marco Martin wrote:
> hmm, yeah, i put it there in order to have it initialized from the
> desktop file then have applets free to override it, but it makes sense to
> have the same behavior for the icons that are set by the plasmoid via api
>
> Marco Martin wrote:
> thinking about it, it doesn't convince me, because then you would have a
> property that you set it to a certain value, then fetch it and is suddenly
> not the value you did set it, don't think is a good behavior?.
so, a plasmoid should use plasmoid.icon = plasmoid.file("images",
"whatever.svgz") in order to set an internal file as plasmoid icon at runtime
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125336/#review85835
-----------------------------------------------------------
On Sept. 21, 2015, 6:11 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125336/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 6:11 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> restore a feature from Plasma4, the ability for plasmoids to provide
> an icon insude their package.
> intended for GHNS plasmoids,
> already used in the widget explorer, this makes it the default plasmoid icon
> as runtime as well.
>
>
> Diffs
> -----
>
> src/plasma/private/applet_p.cpp e2a15b61034e2896ae05893e577c143b6ed3edac
> src/plasma/private/packages.cpp a125f1e1616681837fad3571b8054a4b34bbbaf2
>
> Diff: https://git.reviewboard.kde.org/r/125336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
