----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125277/#review85631 -----------------------------------------------------------
Ship it! fine, tough there should be a complete port of kickoff to kicker backend, that was delayed to not go in 5.4 at the last moment. Eike: what's the status of it? - Marco Martin On Sept. 16, 2015, 11:29 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125277/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 11:29 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > hopefully fixes linked crash > > BUG: 352047 > > > Diffs > ----- > > applets/kickoff/core/recentlyusedmodel.cpp > 27af6a595bfed97292b43be6df46528b1e79f038 > > Diff: https://git.reviewboard.kde.org/r/125277/diff/ > > > Testing > ------- > > Crash is in > > while (d->recentApplicationCount != 0) { > QList<QStandardItem *>items = takeRow(0); > > which implies at some point d->recentApplicationCount got messed up > somewhere, so did a code review on that. > > Seems to still work. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
