----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125223/#review85459 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On Sept. 14, 2015, 2:33 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125223/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 2:33 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: kwayland > > > Description > ------- > > On client side a setTransient method is added which wraps the semantic > of wl_shell_surface_set_transient. > > On server side both set_transient and set_popup are implemented, though > for popup only the transient part is implemented. In particular the grab > is not yet handled and also no popup done is provided. > > For the transient on server side the flags are ignored. Main reason is > that Qt does not use the flag, so testing whether it works is tricky > (needs a test application). > > > Diffs > ----- > > autotests/client/test_wayland_shell.cpp > 89101f4443a1b412a922c99bfe59d06ef1401468 > src/client/shell.h 0777c51da0c2c2568e664af5fe1db51fa5c028bb > src/client/shell.cpp 94eb4de497d3cfd813fb01aa2dc53591ba749f9c > src/server/shell_interface.h dfbc1f077696bdd73039731fd256de656caf9f38 > src/server/shell_interface.cpp a2d241f5d9cdb03a0526c70f2af046c7ec4dc19f > > Diff: https://git.reviewboard.kde.org/r/125223/diff/ > > > Testing > ------- > > See extended autotest. Also KWin extended to make use of it: All kind of > menus (QMenu, context menu, dropdown) are positioned correctly now. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
