> On Sept. 14, 2015, 4:09 p.m., Marco Martin wrote: > > applets/quicklaunch/package/contents/code/layout.js, line 39 > > <https://git.reviewboard.kde.org/r/125222/diff/2/?file=403286#file403286line39> > > > > can you verify that if grid.count changes dinamically, this cols() gets > > re-evaluated immediately? > > David Rosca wrote: > I'm not really sure how to test it, but I added debug output and got this > right after adding item to model: > > ``` > (qml) appendUrl: adding item to model > (qml) appendUrl: added item to model > (qml) onCountChanged: grid count changed > (qml) cols: cols called > (qml) cols: cols called > (qml) cols: cols called > (qml) cols: cols called > ```
yep, it works :) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125222/#review85380 ----------------------------------------------------------- On Sept. 14, 2015, 3:54 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125222/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 3:54 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > This is a reimplementation of Quicklaunch applet in QML. > > I have tried to make it as similar to the original applet as possible. > > Missing features: > - popup drawer for launchers > - option for automatically determining number of rows/cols (must be set > manually) > > > Diffs > ----- > > applets/CMakeLists.txt 2e29bbe > applets/quicklaunch/CMakeLists.txt PRE-CREATION > applets/quicklaunch/Messages.sh PRE-CREATION > applets/quicklaunch/package/contents/code/layout.js PRE-CREATION > applets/quicklaunch/package/contents/config/config.qml PRE-CREATION > applets/quicklaunch/package/contents/config/main.xml PRE-CREATION > applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION > applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION > applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION > applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION > applets/quicklaunch/package/metadata.desktop PRE-CREATION > applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION > applets/quicklaunch/plugin/qmldir PRE-CREATION > applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION > applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION > applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION > applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125222/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Empty applet > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png > On desktop (2 rows) > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png > On desktop with names + dragging > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png > In vertical panel > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png > Context menu > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
