> On Sept. 12, 2015, 9:29 p.m., Martin Klapetek wrote:
> > The text is elided in the Plasma button style, but it has to do with the 
> > width computation in the style, I'm not sure exactly, but my guess is line 
> > 115, the "Math.max(theme.mSize(theme.defaultFont).width*12, 
> > style.minimumWidth);".
> > 
> > So does this fix the linked bug when you use Arial font?

Ah, I've just noticed you fixed the overflowing as well. Good stuff.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125200/#review85273
-----------------------------------------------------------


On Sept. 12, 2015, 8:10 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125200/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 8:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 352125
>     https://bugs.kde.org/show_bug.cgi?id=352125
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Somehow the maximumWidth constraint is not propagated through the Repeater.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationItem.qml 350faa8 
> 
> Diff: https://git.reviewboard.kde.org/r/125200/diff/
> 
> 
> Testing
> -------
> 
> Buttons now respect the maximumWidth
> 
> 
> Thanks,
> 
> David Rosca
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to