----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125058/#review84886 -----------------------------------------------------------
Have you thought of the corner cases? These come to my mind: - Is it possible to add the same folder to both lists? If so: Which one wins? - It ist possible to add a folder to index within an excluded folder? If so: what happens? - Is it possible to exclude a folder which is _not_ within an included folder (not strictly a problem as it would simply have no effect, but strange nonetheless)? - Thomas Pfeiffer On Sept. 5, 2015, 8:11 p.m., Ovidiu-Florin BOGDAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125058/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2015, 8:11 p.m.) > > > Review request for Baloo, Plasma, KDE Usability, Pinak Ahuja, and Vishesh > Handa. > > > Repository: plasma-desktop > > > Description > ------- > > Added the functionality to add directories to be indexed. > Did some cleaning up. > > Screenshot of the new look: http://i.imgur.com/RBWxutv.png > > > Diffs > ----- > > kcms/baloo/CMakeLists.txt 7415289 > kcms/baloo/configwidget.ui 512e4a5 > kcms/baloo/folderselectionwidget.h 226ab45 > kcms/baloo/folderselectionwidget.cpp b44d111 > kcms/baloo/kcm.h 6ff5813 > kcms/baloo/kcm.cpp 27d93e2 > > Diff: https://git.reviewboard.kde.org/r/125058/diff/ > > > Testing > ------- > > Tested add, remove include and exclude directories. > > > Thanks, > > Ovidiu-Florin BOGDAN > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
