> On Sept. 4, 2015, 6:44 p.m., David Edmundson wrote: > > patch looks good, but why are you in the else branch of > > if(X11_Xcursor_FOUND) > > > > ? > > > > You want to fix that on the packaging side rather than having this patch > > Ovidiu-Florin BOGDAN wrote: > I'm working on the baloo KCM, and this stopped me from compiling. > > Seems to me like someone forgot to change these when the folder was > renamed. It like a good fix to me. > > I don't know how to test it.
It is definitely a correct patch, I just assumed (wrongly) that you were asking on behalf of Kubuntu packaging at which point the patch would be uneeded. Do you have commit access in KDE? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125050/#review84845 ----------------------------------------------------------- On Sept. 4, 2015, 6:42 p.m., Ovidiu-Florin BOGDAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125050/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 6:42 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Path was wrong. Could not compile. > > > Diffs > ----- > > kcms/cursortheme/CMakeLists.txt e7613c0 > > Diff: https://git.reviewboard.kde.org/r/125050/diff/ > > > Testing > ------- > > It compiled. > > > Thanks, > > Ovidiu-Florin BOGDAN > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
