----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/#review84787 -----------------------------------------------------------
autotests/client/test_wayland_contrast.cpp (line 172) <https://git.reviewboard.kde.org/r/125030/#comment58685> what do we do about the failing test? src/client/contrast.h (line 24) <https://git.reviewboard.kde.org/r/125030/#comment58682> why include buffer? src/client/contrast.h (lines 32 - 33) <https://git.reviewboard.kde.org/r/125030/#comment58679> why those two? src/client/contrast.h (lines 37 - 38) <https://git.reviewboard.kde.org/r/125030/#comment58681> why those two? src/client/contrast.h (lines 68 - 72) <https://git.reviewboard.kde.org/r/125030/#comment58680> it's not a compositor src/client/contrast.h (line 191) <https://git.reviewboard.kde.org/r/125030/#comment58683> nitpicking src/client/registry.h (line 413) <https://git.reviewboard.kde.org/r/125030/#comment58684> nitpick - Martin Gräßlin On Sept. 2, 2015, 6:23 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125030/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 6:23 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwayland > > > Description > ------- > > new wayland protocol used to define regions behind a window > in which the kwin background contrast effect should be applied > > > Diffs > ----- > > autotests/client/CMakeLists.txt acc1cc0 > autotests/client/test_wayland_contrast.cpp PRE-CREATION > src/client/CMakeLists.txt e269997 > src/client/contrast.h PRE-CREATION > src/client/contrast.cpp PRE-CREATION > src/client/protocols/contrast.xml PRE-CREATION > src/client/registry.h 2a31ab4 > src/client/registry.cpp e890c69 > src/server/CMakeLists.txt 9d99325 > src/server/display.h cd43b03 > src/server/display.cpp 75adc14 > src/server/surface_interface.h f8f9be7 > src/server/surface_interface.cpp 0f62d13 > src/server/surface_interface_p.h 2b55f81 > > Diff: https://git.reviewboard.kde.org/r/125030/diff/ > > > Testing > ------- > > fail in autotests: fun converting between double and "fixed" > Actual (serverSurface->contrast()->contrast()): 0.199219 > Expected (0.2) : 0.2 > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
