> On Sept. 2, 2015, 3:14 p.m., Alex Richardson wrote: > > startkde/kstartupconfig/kdostartupconfig.cpp, line 86 > > <https://git.reviewboard.kde.org/r/124877/diff/1/?file=397209#file397209line86> > > > > `QByteArray buf = keys.readLine()` > > > > I don't see the point of preallocation 1024 bytes (I doubt this does > > any good anyway) and using the less safe C-style API
Or even better just `QString line = QString::fromLocal8Bit(keys.readLine());` - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review84764 ----------------------------------------------------------- On Aug. 31, 2015, 5:33 p.m., Takahiro Hashimoto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124877/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 5:33 p.m.) > > > Review request for Plasma. > > > Bugs: 351609 > https://bugs.kde.org/show_bug.cgi?id=351609 > > > Repository: plasma-workspace > > > Description > ------- > > Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 > generates corrupted files. > > $HOME/.config/startupconfigfiles > $HOME/.config/startupconfig > > > Diffs > ----- > > startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 > > Diff: https://git.reviewboard.kde.org/r/124877/diff/ > > > Testing > ------- > > works for me. > > 1. execute kstartupconfig5 > 2. check if both files are not corrupted. > > > Thanks, > > Takahiro Hashimoto > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
