----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125016/#review84750 -----------------------------------------------------------
src/windowsystem/windoweffects.h (line 30) <https://git.reviewboard.kde.org/r/125016/#comment58657> PlasmaShell is not used src/windowsystem/windoweffects.h (lines 43 - 52) <https://git.reviewboard.kde.org/r/125016/#comment58654> please use override instead of virtual src/windowsystem/windoweffects.h (line 59) <https://git.reviewboard.kde.org/r/125016/#comment58656> why the variable m_blurSupported? If m_waylandBlurManager is not null it's true, otherwise false. Don't see a reason for another variable. src/windowsystem/windoweffects.cpp (line 24) <https://git.reviewboard.kde.org/r/125016/#comment58659> QDebug is not used src/windowsystem/windoweffects.cpp (line 25) <https://git.reviewboard.kde.org/r/125016/#comment58660> QGuiApplication is not used src/windowsystem/windoweffects.cpp (line 29) <https://git.reviewboard.kde.org/r/125016/#comment58658> PlasmaShell is not used src/windowsystem/windoweffects.cpp (line 67) <https://git.reviewboard.kde.org/r/125016/#comment58655> nitpick - Martin Gräßlin On Sept. 1, 2015, 4:58 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125016/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 4:58 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwayland-integration > > > Description > ------- > > implements an empty effects plugin for kwindowsystem, only blur has a full > implementation so far > > > Diffs > ----- > > src/windowsystem/CMakeLists.txt 334ba4f > src/windowsystem/plugin.h c131a85 > src/windowsystem/plugin.cpp 44f5d95 > src/windowsystem/windoweffects.h PRE-CREATION > src/windowsystem/windoweffects.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125016/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
