----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125026/#review84747 -----------------------------------------------------------
Nice! Just a few style nitpicks below, haven't tested it yet. daemon/actions/dpms/abstractdpmshelper.h (lines 18 - 19) <https://git.reviewboard.kde.org/r/125026/#comment58648> Add space, same in other files daemon/actions/dpms/abstractdpmshelper.h (line 27) <https://git.reviewboard.kde.org/r/125026/#comment58649> why = default not here? daemon/actions/dpms/powerdevildpmsaction.cpp (line 45) <https://git.reviewboard.kde.org/r/125026/#comment58650> Why this? daemon/actions/dpms/waylanddpmshelper.h (lines 41 - 42) <https://git.reviewboard.kde.org/r/125026/#comment58651> Add space - Kai Uwe Broulik On Sept. 2, 2015, 7:12 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125026/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 7:12 vorm.) > > > Review request for Plasma, Solid and Kai Uwe Broulik. > > > Repository: powerdevil > > > Description > ------- > > An AbstractDpmsHelper is introduced with a concrete subclass called > XcbDpmsHelper. The PowerDevilDpmsAction holds a helper and delegates > to it. The XcbDpmsHelper implements the X11 specific tasks. This will > allow to add a Wayland implementation as well. > > [dpms] Add a Wayland implementation > > The Wayland implementation uses the DpmsManager provided by KWayland. > On a timeout it turns the screens off and it supports the trigger > modes. The fade helper is not supported (yet) as it is an X11 only > implementation. > > > Diffs > ----- > > CMakeLists.txt 457f74a318588690c3b9890a5bfdb0a4ea887042 > daemon/actions/dpms/CMakeLists.txt 61d7b5684f85c29081dc863abbffa42898089d2a > daemon/actions/dpms/abstractdpmshelper.h PRE-CREATION > daemon/actions/dpms/abstractdpmshelper.cpp PRE-CREATION > daemon/actions/dpms/powerdevildpmsaction.cpp > ac824787d5907e78ce0f3ede0e822ffbc778cb3c > daemon/actions/dpms/powerdevildpmsaction.desktop > 85ec8619bab9da70fddee4d8815ebdb8899000cd > daemon/actions/dpms/powerdevildpmsaction.h > d8b92784abc3717487050928c04c6022480cbd49 > daemon/actions/dpms/waylanddpmshelper.h PRE-CREATION > daemon/actions/dpms/waylanddpmshelper.cpp PRE-CREATION > daemon/actions/dpms/xcbdpmshelper.h PRE-CREATION > daemon/actions/dpms/xcbdpmshelper.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125026/diff/ > > > Testing > ------- > > How I tested: > * run kwin_wayland on a DRM device > * started kded5 > * configured powerdevil to suspend after one minute > * waited > * watched screen go off > * enabled again, looked at debug output to verify it was triggered by > powerdevil. > > It's currently only tested with Qt 5.4. At least for idle integration I had > the problem that things somehow stopped working with 5.5. So this needs > additional testing. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
