----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124918/#review84528 -----------------------------------------------------------
Ship it! Ship It! - Daniel Vrátil On Aug. 28, 2015, 8:48 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124918/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 8:48 a.m.) > > > Review request for Plasma and Daniel Vrátil. > > > Repository: kscreen > > > Description > ------- > > I am not quite confident how this worked (best guess is target order in > cmake). upower_interface.h is not used anywhere, what is used is > freedesktop_interface.h (in device.cpp) an consequently the build can > fail on this file not being found. > > Switch the generated header to the actually used name to avoid build > failures from not being able to find it. > > e.g. > https://launchpadlibrarian.net/215492814/buildlog_ubuntu-wily-i386.kscreen_4%3A5.3.95%2Bgit20150825.0935%2B15.10-0_BUILDING.txt.gz > the error happens and in another concurrent make job the interface is > built in the kded/ directory, so best guess is that this largely depends > on timing to go wrong. > > > Diffs > ----- > > tests/kded/CMakeLists.txt e4b6bf5ec1383807826f312280f1fbea30fe388b > > Diff: https://git.reviewboard.kde.org/r/124918/diff/ > > > Testing > ------- > > make (make test doesn't want to finish for some reason) > > > Thanks, > > Harald Sitter > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
