----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124956/#review84505 -----------------------------------------------------------
The patch is at a wrong place: No matter what KAlarm does, it may not affect the lock screen. We need to ensure in the backend that this does not affect the greeter. Especially we need to ensure that we reset the focus to our greeter on X level. And in addition: your patch sounds very dangerous for multi-monitor setups as now both windows constantly try to regain focus. - Martin Gräßlin On Aug. 27, 2015, 8:53 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124956/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 8:53 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-workspace > > > Description > ------- > > If KAlarm pops up a window when the screen is locked it steals the focus from > the password field. With this patch the focus is stolen back immediately. > > > Diffs > ----- > > lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a00 > > Diff: https://git.reviewboard.kde.org/r/124956/diff/ > > > Testing > ------- > > Set KAlarm to open a new "display alarm" after a minute, lock the screen and > see the focus go away when the minute changes. > > Apply the patch, set KAlarm to open another display alarm, lock the screen > and wait for the minute to change and notice that the focus has not gone > anywhere this time. > > > Thanks, > > Kåre Särs > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
