----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/#review84472 -----------------------------------------------------------
Ship it! Other than Mark's comments; concept of patch is good. I'm glad that it's the shared engine making the timing difference not the sharing component. - David Edmundson On Aug. 27, 2015, 8:34 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124947/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 8:34 a.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-workspace > > > Description > ------- > > In a multi-screen setup we have multiple views showing the same Qml > scene. Let's share the engine for all views. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/CMakeLists.txt > 4fb679f838a80f11eb8e4b4f5cb5ef04dc39c0f7 > ksmserver/screenlocker/greeter/greeterapp.h > ed278e492a9a237f65f4c1600360f84fb25bdad7 > ksmserver/screenlocker/greeter/greeterapp.cpp > b500ba44c2b483d7372ca46840152c90ef5f798c > > Diff: https://git.reviewboard.kde.org/r/124947/diff/ > > > Testing > ------- > > This makes creating a second view basically free (from timing perspective) > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
