----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124730/#review83929 -----------------------------------------------------------
solid-device-automounter/kcm/CMakeLists.txt (line 10) <https://git.reviewboard.kde.org/r/124730/#comment58134> do we need a set_translation_domain? I don't think it comes from KAboutData anymore as the i18n domain is done at compile time. Though I really don't understand most this i18n stuff. solid-device-automounter/kcm/Messages.sh (line 3) <https://git.reviewboard.kde.org/r/124730/#comment58133> might be worth dropping an email to i18n to copy the old pot files from kde-runtime, it might save translations some effort? solid-device-automounter/kded/DeviceAutomounter.cpp (line 95) <https://git.reviewboard.kde.org/r/124730/#comment58132> sa could be null here based on the comment above, at which point you get a huge warning from Qt. solid-device-automounter/lib/AutomounterSettings.cpp (line 54) <https://git.reviewboard.kde.org/r/124730/#comment58135> this comment doesn't match line 72 we're doing this if the device-specific automount is false. I /think/ it's the comment that's wrong rather than the code The code says: If there's no device specific setting, look at general settings. which makes sense. All reviewed. Only some minor comments, then I think we're all good. - David Edmundson On Aug. 16, 2015, 6:43 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124730/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2015, 6:43 p.m.) > > > Review request for Plasma, Solid and Torrie Fischer. > > > Bugs: 351003 > https://bugs.kde.org/show_bug.cgi?id=351003 > > > Repository: plasma-desktop > > > Description > ------- > > This is a straight port of the solid-device-automounter from kde-runtime that > was somehow lost to plasma-desktop. I didn't do git graft magic (can this be > done later? ie. import kde-runtime folder here to there and then apply a diff > on top?). > > > Diffs > ----- > > CMakeLists.txt 4717780 > solid-device-automounter/CMakeLists.txt PRE-CREATION > solid-device-automounter/COPYING PRE-CREATION > solid-device-automounter/SETTINGS PRE-CREATION > solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION > solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION > solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION > solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION > solid-device-automounter/kcm/DeviceModel.h PRE-CREATION > solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION > solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION > solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION > solid-device-automounter/kcm/Messages.sh PRE-CREATION > solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION > solid-device-automounter/kded/CMakeLists.txt PRE-CREATION > solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION > solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION > solid-device-automounter/kded/device_automounter.desktop PRE-CREATION > solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION > solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION > solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION > solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124730/diff/ > > > Testing > ------- > > Seems to work, translations are probably broken. > Told it to auto mount all the things, did that. Told it to mount just one > thing automatically, did that. Somehow the list of non-attached devices grows > even when I re-attach the same device. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
