-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124668/
-----------------------------------------------------------

(Updated Авг. 9, 2015, 5:33 д.п.)


Review request for Plasma, David Edmundson and Martin Klapetek.


Changes
-------

Reviewboard is broken with 3200x2000 images. It accepts them and makes 
thumbnails, but trying to view the original images gives 403 error.

I uploaded a cropped version that shows just the top-left part.

Full images before: 
http://quickgit.kde.org/?p=breeze.git&a=tree&hb=cd4328238&f=wallpapers%2FNext%2Fcontents%2Fimages
Full versions after: 
http://oserv.org/files/kde/wallpaper-horizon/desktopWallpaper-horizon-1.1-kvermette.splitnoise.svg.out.x4/images/


Description
-------

Atm, 5.4 wallpapers have pixelated lines and blurred noise (the same as 
https://bugs.kde.org/show_bug.cgi?id=346018 for 5.3).

I re-rendered them using the same script (4x supersample antialiasing and split 
noise).

Split noise means that the noise pattern is not scaled for the different 
resolution wallpapers (which looked bad on both too low and too high 
resolutions), but is post-applied and tiled.

I uploaded the renders and the patch against the 'breeze' repo to 
http://oserv.org/files/kde/wallpaper-horizon/ 

Also there is an updated version of the script (render.sh), but the only 
difference from the previous version is that I added some more comments at the 
top.

When reviewing, everything should be viewed at 1:1 scale.


Diffs
-----


Diff: https://git.reviewboard.kde.org/r/124668/diff/


Testing
-------

Just opened the wallpapers at 1:1 scale and compared them.
Also I put the corresponding resolution version as my current wallpaper =).


File Attachments (updated)
----------------

1024x768 before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/759129c3-b0c6-40a4-96a2-45489899c0cd__1024x768.png
1024x768 after
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/0800d133-08a1-4599-9942-25e3762c5ab0__1024x768.png
3200x2000 before (top-left part)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/95c0b177-209f-4fe6-a1c8-ead02199f32d__3200x2000-topleft-before.png
3200x2000 after (top-left part)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/61e34da3-b9eb-4a88-b2b7-455bf3dcc322__3200x2000-topleft-after.png


Thanks,

Nikita Skovoroda

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to