> On Aug. 6, 2015, 11:51 a.m., Mark Gaiser wrote: > > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp, line 153 > > <https://git.reviewboard.kde.org/r/124634/diff/1/?file=390499#file390499line153> > > > > qCDebug perhaps? > > Martin Klapetek wrote: > I would even throw it out altogether, it's useful while developing this > patch but other than that it will just add not-so-useful noise to plasma > output.
I already did before submitting. :) - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124634/#review83484 ----------------------------------------------------------- On Aug. 5, 2015, 10:35 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124634/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 10:35 p.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-workspace > > > Description > ------- > > Filter applets by formFactor > > This patch allows to filter the loaded Plasmoids by formFactor. It uses > a property of host, and passes this down to the PlasmoidProtocol, which > then decides based on formFactor whether or not to show a Plasmoid. > > The value for FormFactor can be changed from QML. > > This patch requires https://git.reviewboard.kde.org/r/124632/ to work > correctly, but it won't hide any applet until then. It's safe to use even > without above patch. > > REVIEW: > > > Diffs > ----- > > applets/systemtray/package/contents/ui/main.qml > 0d01654bb264f79010ef15418e0e4c5498a4661c > applets/systemtray/plugin/host.h c7ffac7043ac8e668ab582d3508eb4facbe252e8 > applets/systemtray/plugin/host.cpp dfb294a9574685060a80afe9a26665c7f61c15b8 > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h > 2776c2fa40e05c6c6aa2dcfa31f37033712a4d36 > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp > 66d8a6a48a1ad5bce3fc27e2e83b3a26be3e4f6e > > Diff: https://git.reviewboard.kde.org/r/124634/diff/ > > > Testing > ------- > > Tried "desktop" and "handset" Formfactor to show / hide the mobile battery > applet in the systray. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
