----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124449/#review83372 -----------------------------------------------------------
Ship it! applets/digital-clock/package/contents/ui/DigitalClock.qml (line 334) <https://git.reviewboard.kde.org/r/124449/#comment57619> have you considered changing the flow direction rather than having two labels and toggling visiblity? - David Edmundson On July 28, 2015, 11:21 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124449/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 11:21 a.m.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 348072 > https://bugs.kde.org/show_bug.cgi?id=348072 > > > Repository: plasma-workspace > > > Description > ------- > > One of the most reported bugs wrt digital clock is that the second line > text (date or timezone) is unreadable on small panels so this adds new > state to the clock applet that lays things horizontally when the panel > is too small to show text with the "small" font (set in system settings). > > When there is a date displayed, a delimiter is put in between to allow > easier and faster spotting the time (as on a first glance there is just > a bunch of numbers, so quickly orienteering is super important). I used > the dot symbol first but then went for pipe which I think looks more clean; > see screenshots for comparison. > > I've made a quick video showing the state changes, > see https://www.youtube.com/watch?v=t7w0k8H22h4 - it shows the bullet > delimiter and a bit wrong spacing which is now fixed. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078 > > Diff: https://git.reviewboard.kde.org/r/124449/diff/ > > > Testing > ------- > > Everything works as it used and now with small panel things are layed > horizontally, see video above. > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/0173583e-08ec-455b-9417-42d390aac81d__clock-rect-delimiter2.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
