----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124571/#review83270 -----------------------------------------------------------
src/accountinfo.cpp (line 183) <https://git.reviewboard.kde.org/r/124571/#comment57496> This is deprecated API http://doc.qt.io/qt-5/qdesktopservices-obsolete.html See QStandardPaths src/lib/accountmodel.cpp (line 58) <https://git.reviewboard.kde.org/r/124571/#comment57497> leaks also, it's better in where we construct m_sessions on line 39. Otherwise we have a dangly pointer for half the contstructor, and when someone rearranges the code in the future they get a crash - David Edmundson On July 31, 2015, 9:17 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124571/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 9:17 p.m.) > > > Review request for Plasma. > > > Repository: user-manager > > > Description > ------- > > Save settings with m_kEmailSettings as well to replace kcm_useraccounts > add symlink in ~/.face.icon the file used by some login managers > > with this we can get rid of kcm_useraccounts which just duplicates it > > > Diffs > ----- > > src/accountinfo.cpp 78fe969 > src/lib/accountmodel.h 331c131 > src/lib/accountmodel.cpp 558aa6b > > Diff: https://git.reviewboard.kde.org/r/124571/diff/ > > > Testing > ------- > > edited user settings and checked ~/.config/emailsettingsrc > > edited user settings and checked ~/.face* > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
