> On July 31, 2015, 7:26 p.m., Martin Gräßlin wrote: > > The copy of dialog.h somehow scares me - is there no other way? I'm afraid > > it will totally get out of sync especially given that the release cycles > > are not synced.
ah, that copy is already around.. an alternative is to completely give up and install the headers so that's officially "released". we won't get to change abi ever anyways i guess since stuff from that library is already used too much around - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124555/#review83262 ----------------------------------------------------------- On July 31, 2015, 3:23 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124555/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 3:23 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > since we can't subclass Dialog (created from QML) inject a class that will > control it with event filters from the shell (in an eventfilter as well > installed on the qapp) > > > Diffs > ----- > > shell/CMakeLists.txt 3cfc84b > shell/plasmaquick/dialog.h PRE-CREATION > shell/shellcorona.h 9e93844 > shell/shellcorona.cpp fbffbb0 > shell/waylanddialogfilter.h PRE-CREATION > shell/waylanddialogfilter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124555/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
