> On Juli 28, 2015, 8:37 nachm., Martin Klapetek wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 147-149 > > <https://git.reviewboard.kde.org/r/124397/diff/3/?file=388457#file388457line147> > > > > Given this is only used here, would it make more sense to actually move > > the function here? Having it on the main item does not seem to bring any > > advantages...
resetToday in MonthView.qml is used for example by org.kde.plasma.digitalclock/contents/ui/CalendarView.qml I don't know where else it is also used.. - Bernhard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review83118 ----------------------------------------------------------- On Juli 28, 2015, 8:32 nachm., Bernhard Friedreich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124397/ > ----------------------------------------------------------- > > (Updated Juli 28, 2015, 8:32 nachm.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 348362 > http://bugs.kde.org/show_bug.cgi?id=348362 > > > Repository: plasma-framework > > > Description > ------- > > Add button "Select Today" to calendar title bar > > BUG: 348362 > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DaysCalendar.qml > 35a1e202ced1c050479ed04d71d8976a4e03a12c > > Diff: https://git.reviewboard.kde.org/r/124397/diff/ > > > Testing > ------- > > plasmoidviewer with digitalclock plasmoid > added digitalclock plasmoid to desktop > > clicked digital clock plasmoid to view calendar > "Select Today" button is shown > select different day > clicked button -> selection changes to today > moved to another month/month selection/year/year selection -> clicked button > --> jumps to today > > > File Attachments > ---------------- > > Plasmoidviewer Digital Clock showing Calendar with Today ToolButton > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png > > > Thanks, > > Bernhard Friedreich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
