-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124507/#review83088
-----------------------------------------------------------



src/declarativeimports/calendar/qml/DaysCalendar.qml (line 70)
<https://git.reviewboard.kde.org/r/124507/#comment57367>

    should scaleBehaviorEnabled be reset here?



src/declarativeimports/calendar/qml/MonthView.qml (line 235)
<https://git.reviewboard.kde.org/r/124507/#comment57366>

    I think it's better too have the Stack.onStatusChanged here.
    
    All stackview code is in this class, and all other setting of scale happens 
in here.
    
    If you disagree, leave it as it is though. I don't really mind.


- David Edmundson


On July 28, 2015, 12:23 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124507/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 12:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Now you can pinch to zoom out in the calendar. Why? Because we can!
> 
> https://www.youtube.com/watch?v=i8a-MPyzMOw
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e20 
>   src/declarativeimports/calendar/qml/MonthView.qml 57ac59a 
> 
> Diff: https://git.reviewboard.kde.org/r/124507/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to