> On Juli 26, 2015, 7:43 vorm., David Edmundson wrote: > > ksmserver/screenlocker/logind.h, line 70 > > <https://git.reviewboard.kde.org/r/124469/diff/1/?file=387737#file387737line70> > > > > our normal naming is m_lowerCamelCase > > > > also, can you set these to 0. > > > > > > const QString *m_service = 0; > > I know you set these before use but it makes debugging a backtrace > > easier if they do ever get used early somewhere in the future
= nullptr :) - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124469/#review82970 ----------------------------------------------------------- On Juli 26, 2015, 7:13 vorm., Eric Koegel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124469/ > ----------------------------------------------------------- > > (Updated Juli 26, 2015, 7:13 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > ConsoleKit2 has the same API as systemd-logind for Lock, Unlock, > PrepareForSleep, and Inhibit. This patch adds the functionality > for ConsoleKit2 while attempting to minimize code duplication. > > > Diffs > ----- > > ksmserver/screenlocker/logind.h 9983673 > ksmserver/screenlocker/logind.cpp 5335b15 > > Diff: https://git.reviewboard.kde.org/r/124469/diff/ > > > Testing > ------- > > dbus-send --system --dest=org.freedesktop.ConsoleKit --type=method_call > --print-reply --reply-timeout=2000 /org/freedesktop/ConsoleKit/Manager > org.freedesktop.ConsoleKit.Manager.ListInhibitors > method return sender=:1.1 -> dest=:1.80 reply_serial=2 > array [ > struct { > string "suspend" > string "NetworkManager" > string "NetworkManager needs to turn off networks" > string "delay" > uint32 0 > uint32 3473 > } > struct { > string > "handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch" > string "PowerDevil" > string "KDE handles power events" > string "block" > uint32 1000 > uint32 9587 > } > struct { > string "suspend" > string "Screen Locker" > string "Ensuring that the screen gets locked before going to sleep" > string "delay" > uint32 1000 > uint32 9508 > } > ] > > Verified ConsoleKit2 does delay suspending until both delay locks are removed. > > > Thanks, > > Eric Koegel > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
