> On Juli 16, 2015, 11:33 nachm., Aleix Pol Gonzalez wrote:
> > cmake/FindQalculate.cmake, line 39
> > <https://git.reviewboard.kde.org/r/123557/diff/1/?file=364384#file364384line39>
> >
> > Shouldn't pkgconfig give us that?
${_pc_QALCULATE_LIBRARY_DIRS} is used in the find_library call. This seems to
be a common pattern in FindXYZ cmake modules.
- Heiko
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123557/#review82593
-----------------------------------------------------------
On Juli 19, 2015, 10:40 vorm., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123557/
> -----------------------------------------------------------
>
> (Updated Juli 19, 2015, 10:40 vorm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The latter is deprecated and doesn't respect the PKG_CONFIG
> environment variable which makes it easy to deal with differently
> named pkg-config executables, e.g. arch-prefixed ones.
>
>
> Diffs
> -----
>
> cmake/FindQalculate.cmake 72d65bc
>
> Diff: https://git.reviewboard.kde.org/r/123557/diff/
>
>
> Testing
> -------
>
> Configured, built and checked that plasma-workspace links to qualculate and
> cln.
>
>
> Thanks,
>
> Heiko Becker
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
