----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/#review82076 -----------------------------------------------------------
ConfigureChecks.cmake (line 3) <https://git.reviewboard.kde.org/r/124215/#comment56404> Hard-coding the pkg-config executable breaks on my multiarch distro with a arch prefixed pkg-config, which is also common when cross compiling. Better use find_package(PkgConfig) and ${PKG_CONFIG_EXECUTABLE} which amongst other things respects the PKG_CONFIG env variable. - Heiko Becker On Juli 1, 2015, 11:07 nachm., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124215/ > ----------------------------------------------------------- > > (Updated Juli 1, 2015, 11:07 nachm.) > > > Review request for Plasma. > > > Bugs: 349658 > https://bugs.kde.org/show_bug.cgi?id=349658 > > > Repository: plasma-desktop > > > Description > ------- > > Instead of looking for X11 libraries and then looking stuff up, just find the > directory we're looking for. > Also drop XBINDIR, as it wasn't being used at all. > > Should give something like this directory: > ``` > $ ls /usr/share/X11/xkb/ > compat geometry keycodes rules symbols types > ``` > > > Diffs > ----- > > ConfigureChecks.cmake 4fc4bce > config-workspace.h.cmake eda8996 > kcms/keyboard/xkb_rules.cpp 9fd0324 > > Diff: https://git.reviewboard.kde.org/r/124215/diff/ > > > Testing > ------- > > re-compiled on my system, everything still works. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
