-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124149/
-----------------------------------------------------------
Review request for Plasma and Kai Uwe Broulik.
Bugs: 339588 and 349142
https://bugs.kde.org/show_bug.cgi?id=339588
https://bugs.kde.org/show_bug.cgi?id=349142
Repository: plasma-workspace
Description
-------
This reworks the notification sizing computation to use Layouts. This should
fix all the popup sizing issues there are (including a binding loop error).
Now it also properly elides after max 4 lines of text.
Diffs
-----
applets/notifications/package/contents/ui/NotificationItem.qml 176ae91
applets/notifications/package/contents/ui/NotificationPopup.qml e4e5fad
Diff: https://git.reviewboard.kde.org/r/124149/diff/
Testing
-------
I've been running it for couple hours, all notifications have correct sizes,
see screenshot
File Attachments
----------------
Screenshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/f4f7689c-2a95-46aa-8e51-e90d25d99bb2__notifications-layout.png
Thanks,
Martin Klapetek
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
