----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124114/#review81518 -----------------------------------------------------------
Ship it! > This does not check KAuthorized before to hide the entry but neither does the > context menu. Well that's a bit rubbish. Ship this, but lets remember to fix both, poke me if it gets near release and I haven't. BTW, is it possible to power this menu from the QActions we have in Plasma, I haven't looked but it should reduce some code? - David Edmundson On June 16, 2015, 8:18 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124114/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 8:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > It used to be present in 4.x and makes it consistent with what the context > menu provides. This does not check KAuthorized before to hide the entry but > neither does the context menu. As suggested in > https://forum.kde.org/viewtopic.php?f=289&t=126770 > > > Diffs > ----- > > toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml c2a36e9 > > Diff: https://git.reviewboard.kde.org/r/124114/diff/ > > > Testing > ------- > > Works > > > File Attachments > ---------------- > > Lock screen entry > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/16/1c037bef-4280-4da8-bf9c-7cdc3d0e37b6__lockscreentoolbox.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
