----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124037/#review81330 -----------------------------------------------------------
Simple cancel without a countdown makes not much sense. Do I have bone-breaking 10sec or more? Or is it the small progressbar right hand? It would be good to have some text as well. By the way: ellipsis in this widget are not so good (guess the full text is shown in a tooltip). I'd recommend "Battery-low condition" as title plus sub text "remaining: 2%/~10min" and "shutdown in: 10s" with the option to cancel, if relevant. Does the safety shutdown pops-up again or is it the user's duty now to care about saving stuff? I'm not sure if overriding safety features is a good idea in general. - Heiko Tietze On Juni 8, 2015, 5:30 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124037/ > ----------------------------------------------------------- > > (Updated Juni 8, 2015, 5:30 nachm.) > > > Review request for Plasma, Solid and KDE Usability. > > > Repository: powerdevil > > > Description > ------- > > To prevent David from eventually breaking his bones tumbling down the stairs > rushing for his AC adapter, this adds a "Cancel" button to the battery > critical notification that allows to cancel the timeout for automatic > suspend/shutdown. > > > Diffs > ----- > > daemon/powerdevilcore.h 50e6a50 > daemon/powerdevilcore.cpp e90a960 > > Diff: https://git.reviewboard.kde.org/r/124037/diff/ > > > Testing > ------- > > Got a "Cancel" button only when it was configured to do something, clicking > the button from both popup and history cancelled the timeout. (Unfortunately > the notification doesn't fit into the popup at all now) > > > File Attachments > ---------------- > > Notification with close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/07/f99c0164-4436-462f-974b-ddc5df0ce500__powerdevilcanceltimeout.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
